test overriding a local function

This commit is contained in:
Lysann Tranvouez 2025-10-01 23:55:17 +02:00
parent 4947fb5553
commit 5e76138b53
7 changed files with 81 additions and 1 deletions

View file

@ -4,6 +4,8 @@
#include <mach_detours.h>
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
#include "test_func.h"
static int testFunctionDetourCounter = 0;
@ -13,7 +15,7 @@ int testFunctionDetour()
return 94;
}
TEST_CASE( "Overriding custom function" )
TEST_CASE( "Overriding custom function in dylib" )
{
int (*realTestFunction)() = testFunction;
testFunctionCounter = 0;
@ -35,3 +37,43 @@ TEST_CASE( "Overriding custom function" )
REQUIRE( testFunctionCounter == 1 );
REQUIRE( testFunctionDetourCounter == 1 );
}
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
static int localFunctionCounter = 0;
int localFunction()
{
localFunctionCounter++;
return 67;
}
static int localFunctionDetourCounter = 0;
int localFunctionDetour()
{
localFunctionDetourCounter++;
return 12;
}
TEST_CASE( "Overriding local function" )
{
int (*realFunction)() = localFunction;
localFunctionCounter = 0;
localFunctionDetourCounter = 0;
REQUIRE( localFunction() == 67 );
REQUIRE( localFunctionCounter == 1 );
REQUIRE( localFunctionDetourCounter == 0 );
CHECK( detour_transaction_begin() == err_none );
// Overriding a local function requires using detour_attach_and_commit instead of calling attach and commit individually.
// Otherwise when we return from attach (and before commit), the code page with the local function is marked as read+write (but _not_ executable).
// There is a good chance the code we return to (in this case the test function) is on the same memory page and can therefore not be executed (until we call commit).
CHECK( detour_attach_and_commit(reinterpret_cast<detour_func_t*>(&realFunction), reinterpret_cast<detour_func_t>(localFunctionDetour)) == err_none );
REQUIRE( realFunction != localFunction );
REQUIRE( localFunctionCounter == 1 );
REQUIRE( localFunctionDetourCounter == 0 );
REQUIRE( localFunction() == 12 );
REQUIRE( localFunctionCounter == 1 );
REQUIRE( localFunctionDetourCounter == 1 );
}