small test restructure again

This commit is contained in:
Lysann Tranvouez 2025-10-02 22:44:29 +02:00
parent 5d833e2928
commit 7257abce71

View file

@ -14,65 +14,66 @@ static int libFunctionDetour()
return 94; return 94;
} }
TEST_CASE( "Overriding custom function in dylib", "[attach][detach][dylib]" ) TEST_CASE( "Attaching custom function in dylib installs detour", "[attach][dylib]" )
{ {
libFunctionCounter = 0; libFunctionCounter = 0;
libFunctionDetourCounter = 0; libFunctionDetourCounter = 0;
SECTION( "attaching installs a detour" ) REQUIRE( realLibFunction == libFunction );
REQUIRE( libFunction() == 42 );
REQUIRE( libFunctionCounter == 1 );
REQUIRE( libFunctionDetourCounter == 0 );
REQUIRE( detour_transaction_begin() == err_none );
SECTION( "attach + transaction_commit" )
{ {
REQUIRE( realLibFunction == libFunction ); REQUIRE( detour_attach(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
REQUIRE( libFunction() == 42 ); CHECK( detour_transaction_commit() == err_none );
REQUIRE( libFunctionCounter == 1 ); }
REQUIRE( libFunctionDetourCounter == 0 ); SECTION( "attach_and_commit" )
{
CHECK( detour_attach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
}
REQUIRE( detour_transaction_begin() == err_none ); CHECK( realLibFunction != libFunction );
CHECK( libFunctionCounter == 1 );
CHECK( libFunctionDetourCounter == 0 );
CHECK( libFunction() == 94 );
CHECK( libFunctionCounter == 1 );
CHECK( libFunctionDetourCounter == 1 );
SECTION( "attach + transaction_commit" ) // clean up
{ REQUIRE( detour_transaction_begin() == err_none );
REQUIRE( detour_attach(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none ); CHECK( detour_detach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
CHECK( detour_transaction_commit() == err_none ); }
}
SECTION( "attach_and_commit" )
{
CHECK( detour_attach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
}
CHECK( realLibFunction != libFunction ); TEST_CASE( "Detaching custom function in dylib removes detour", "[detach][dylib]" )
CHECK( libFunctionCounter == 1 ); {
CHECK( libFunctionDetourCounter == 0 ); libFunctionCounter = 0;
CHECK( libFunction() == 94 ); libFunctionDetourCounter = 0;
CHECK( libFunctionCounter == 1 );
CHECK( libFunctionDetourCounter == 1 );
// clean up REQUIRE( detour_transaction_begin() == err_none );
REQUIRE( detour_transaction_begin() == err_none ); REQUIRE( detour_attach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
REQUIRE( realLibFunction != libFunction );
// this must be a separate transaction because detach works only if the trampoline is actually in place already (committed)
REQUIRE( detour_transaction_begin() == err_none );
SECTION( "detach + transaction_commit" )
{
REQUIRE( detour_detach(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
CHECK( detour_transaction_commit() == err_none );
}
SECTION( "detach_and_commit" )
{
CHECK( detour_detach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none ); CHECK( detour_detach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
} }
SECTION( "detaching in separate transaction removes detour" ) CHECK( realLibFunction == libFunction );
{ CHECK( libFunctionCounter == 0 );
REQUIRE( detour_transaction_begin() == err_none ); CHECK( libFunctionDetourCounter == 0 );
REQUIRE( detour_attach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none ); CHECK( libFunction() == 42 );
REQUIRE( realLibFunction != libFunction ); CHECK( libFunctionCounter == 1 );
CHECK( libFunctionDetourCounter == 0 );
REQUIRE( detour_transaction_begin() == err_none );
SECTION( "detach + transaction_commit" )
{
REQUIRE( detour_detach(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
CHECK( detour_transaction_commit() == err_none );
}
SECTION( "detach_and_commit" )
{
CHECK( detour_detach_and_commit(reinterpret_cast<detour_func_t*>(&realLibFunction), reinterpret_cast<detour_func_t>(libFunctionDetour)) == err_none );
}
CHECK( realLibFunction == libFunction );
CHECK( libFunctionCounter == 0 );
CHECK( libFunctionDetourCounter == 0 );
CHECK( libFunction() == 42 );
CHECK( libFunctionCounter == 1 );
CHECK( libFunctionDetourCounter == 0 );
}
} }