78e3abb0d8
* Naming
* If this is not some OpenPGP standard I follow rule that `DES` should be
upper case as it is abreviation and `Triple` should be camel-case as it
is normal word hence `TripleDES`
* rename `errors2` -> `errorsPGP`
* long lines
* https://github.com/golang/go/wiki/CodeReviewComments#line-length
* I bit improved long lines based on my folding
* reuse type in definition if possible i.e. `a string, b string, c string` -> `a,b,c string`
* `if long_statetent(); err!=nil {` -> `long_statement;↵ if err!=nil {`
* spaces around operators (e.g. `a + b` -> `a+b`)
* removing empty lines on start and end of scope
* comments
* on all exported functions
* start with function name
* import:
* order in alphabet
* separate native, golang.org/x/ and our libs
34 lines
1.1 KiB
YAML
34 lines
1.1 KiB
YAML
variables:
|
|
# Please edit to your GitLab project
|
|
REPO_NAME: github.com/ProtonMail/go-pm-crypto
|
|
|
|
before_script:
|
|
- 'which ssh-agent || ( apt-get update -y && apt-get install openssh-client -y )'
|
|
- eval $(ssh-agent -s)
|
|
- echo "$SSH_PRIVATE_KEY" | tr -d '\r' | ssh-add - > /dev/null
|
|
- export PATH=/opt/local/bin:$PATH
|
|
- mkdir -p $GOPATH/src/$(dirname $REPO_NAME)
|
|
- ln -svf $CI_PROJECT_DIR $GOPATH/src/$REPO_NAME
|
|
- cd $GOPATH/src/$REPO_NAME
|
|
- glide install
|
|
|
|
stages:
|
|
- test
|
|
|
|
test-all:
|
|
stage: test
|
|
image: gitlab.protontech.ch:4567/protonmail/import-export/linux
|
|
script:
|
|
- go test -coverprofile cover.out ./...
|
|
- mkdir reports
|
|
- go tool cover -html=cover.out -o reports/cover.html
|
|
- go run vendor/github.com/golangci/golangci-lint/cmd/golangci-lint/main.go run crypto/... --enable-all -D govet -D interfacer -D gofmt -D prealloc -D gochecknoglobals -D goimports -D gosec -D gocritic -D gochecknoinits
|
|
tags:
|
|
- coverage
|
|
artifacts:
|
|
paths:
|
|
- reports
|
|
reports:
|
|
junit: reports/cover.html
|
|
when: always
|
|
expire_in: 5 days
|