From 25dd1339bf7fcf56470025c82f679550d599cdcf Mon Sep 17 00:00:00 2001 From: Yishi Lin Date: Thu, 8 Jun 2017 16:52:37 +0800 Subject: [PATCH 1/4] Update readme Add the link to App Store! --- README.md | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index 573f8c6..bc7facb 100644 --- a/README.md +++ b/README.md @@ -10,20 +10,20 @@ Pass is an iOS client compatible with [ZX2C4's Pass command line application](http://www.passwordstore.org/). It is a password manager using GPG for encryption and Git for version control. -Pass for iOS is under *TestFlight external testing*. Drop an email to -`developer@passforios.mssun.me` for testing. Thank you. +Pass for iOS is available in the [App Store](https://appsto.re/us/DY13hb.i) +with the name "Pass - Password Store". If you want to join the iOS beta via +Testflight, drop an email to `developer@passforios.mssun.me`. Thank you. ## Features - Try to be compatible with the Password Store command line tool -- Support to view, copy, add, edit password entries +- Support to view, copy, add, and edit password entries - Encrypt and decrypt password entries by PGP keys - Synchronize with your password Git repository - User-friendly interface: search, long press to copy, copy and open link, etc. - Support one-time password (OTP) tokens (QR code and otpauth URI) - Written in Swift - No need to jailbreak your devices -- Get from App Store (stay tuned) ## Screenshots @@ -34,7 +34,15 @@ Pass for iOS is under *TestFlight external testing*. Drop an email to

-## Build +## Usages + +- Setup your password-store ([official `Pass` introduction](https://www.passwordstore.org/)) +- Get Pass for iOS from the App Store or build one by yourself +- Start to use Pass for iOS on your iPhone/iPad ([quick-start guide](https://github.com/mssun/passforios/wiki#quick-start-guide-for-pass-for-ios)) + +For more, please read the [wiki page](https://github.com/mssun/pass-ios/wiki). + +## Building Pass for iOS 1. Install libtool, automake, cmake, carthage, and cocoapods: `brew install libtool automake cmake carthage cocoapods` @@ -44,16 +52,6 @@ Pass for iOS is under *TestFlight external testing*. Drop an email to 4. Open `.xcworkspace` file in Xcode. 5. Build & Run. -## Usage - -- Generate a PGP key pair -- Use the `pass` command line tool -- Push encrypted password store to a private Git repository -- Build Pass for iOS by yourself or download from App Store -- Start to use Pass for iOS on your iPhone/iPad - -For more, please read the [wiki page](https://github.com/mssun/pass-ios/wiki). - ## License MIT From 6dbab509e0e3c00c076f41b53ebde8e1f35c8700 Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Sun, 11 Jun 2017 17:51:33 -0700 Subject: [PATCH 2/4] Fix #90 --- pass/Models/PasswordStore.swift | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pass/Models/PasswordStore.swift b/pass/Models/PasswordStore.swift index 26e8ab0..85b89dc 100644 --- a/pass/Models/PasswordStore.swift +++ b/pass/Models/PasswordStore.swift @@ -234,8 +234,7 @@ class PasswordStore { if fm.fileExists(atPath: storeURL.path) { try fm.removeItem(at: storeURL) } - try fm.copyItem(at: tempStoreURL, to: storeURL) - try fm.removeItem(at: tempStoreURL) + try fm.moveItem(at: tempStoreURL, to: storeURL) storeRepository = try GTRepository(url: storeURL) } catch { credential.delete() From e6f90bcc0d66fb4d0d626a39e8809b3685eeeb0f Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Tue, 13 Jun 2017 20:30:01 -0700 Subject: [PATCH 3/4] Add paypal donation button --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index bc7facb..b796cfb 100644 --- a/README.md +++ b/README.md @@ -5,6 +5,7 @@ ![Swift 3.1](https://img.shields.io/badge/Swift-3.1-orange.svg) [![Gitter](https://img.shields.io/gitter/room/nwjs/nw.js.svg)](https://gitter.im/passforios/passforios) [![Build Status](https://travis-ci.org/mssun/passforios.svg?branch=develop)](https://travis-ci.org/mssun/passforios) +[![Donate](https://img.shields.io/badge/Paypal-donate-blue.svg)](https://www.paypal.me/mssun) Pass is an iOS client compatible with [ZX2C4's Pass command line application](http://www.passwordstore.org/). It is a password manager using From 077e046a0e81cabcd72b2bbaf0983f57ca31d58c Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Tue, 13 Jun 2017 21:21:46 -0700 Subject: [PATCH 4/4] Fix a bug caused by NSPredicate mistake --- pass/Models/PasswordStore.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pass/Models/PasswordStore.swift b/pass/Models/PasswordStore.swift index 85b89dc..e96976e 100644 --- a/pass/Models/PasswordStore.swift +++ b/pass/Models/PasswordStore.swift @@ -213,7 +213,7 @@ class PasswordStore { func getPasswordEntity(by path: String, isDir: Bool) -> PasswordEntity? { let passwordEntityFetchRequest = NSFetchRequest(entityName: "PasswordEntity") do { - passwordEntityFetchRequest.predicate = NSPredicate(format: "path = %@ and isDir = %@", path, isDir.description) + passwordEntityFetchRequest.predicate = NSPredicate(format: "path = %@ and isDir = %@", path, isDir as NSNumber) return try context.fetch(passwordEntityFetchRequest).first as? PasswordEntity } catch { fatalError("Failed to fetch password entities: \(error)")