From 44870af7740f5faee0d17a1a53e1f3e300c7f403 Mon Sep 17 00:00:00 2001
From: Danny Moesch <danny.moesch@icloud.com>
Date: Sat, 4 May 2019 22:15:23 +0200
Subject: [PATCH] Trust in assigned default value

In particular, SwiftyUserDefaults returns the default value in case it does not find a value in the dictionary. As the default is '.all' it does not have to be set explicitly. Assigning 'nil' will result in '.all' anyway.
---
 pass/Controllers/PasswordsViewController.swift | 2 +-
 passKit/Helpers/DefaultsKeys.swift             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pass/Controllers/PasswordsViewController.swift b/pass/Controllers/PasswordsViewController.swift
index d032f58..d356875 100644
--- a/pass/Controllers/PasswordsViewController.swift
+++ b/pass/Controllers/PasswordsViewController.swift
@@ -585,7 +585,7 @@ class PasswordsViewController: UIViewController, UITableViewDataSource, UITableV
 
     func searchBar(_ searchBar: UISearchBar, selectedScopeButtonIndexDidChange selectedScope: Int) {
         // update the default search scope
-        SharedDefaults[.searchDefault] = SearchBarScope(rawValue: selectedScope) ?? .all
+        SharedDefaults[.searchDefault] = SearchBarScope(rawValue: selectedScope)
         updateSearchResults(for: searchController)
     }
 
diff --git a/passKit/Helpers/DefaultsKeys.swift b/passKit/Helpers/DefaultsKeys.swift
index 016d0cf..3218d5a 100644
--- a/passKit/Helpers/DefaultsKeys.swift
+++ b/passKit/Helpers/DefaultsKeys.swift
@@ -40,7 +40,7 @@ public extension DefaultsKeys {
     static let isRememberGitCredentialPassphraseOn = DefaultsKey<Bool>("isRememberGitCredentialPassphraseOn", defaultValue: false)
     static let isShowFolderOn = DefaultsKey<Bool>("isShowFolderOn", defaultValue: true)
     static let isHidePasswordImagesOn = DefaultsKey<Bool>("isHidePasswordImagesOn", defaultValue: false)
-    static let searchDefault = DefaultsKey<SearchBarScope>("searchDefault", defaultValue: .all)
+    static let searchDefault = DefaultsKey<SearchBarScope?>("searchDefault", defaultValue: .all)
     static let passwordGeneratorFlavor = DefaultsKey<String>("passwordGeneratorFlavor", defaultValue: "Apple")
 
     static let encryptInArmored = DefaultsKey<Bool>("encryptInArmored", defaultValue: false)