lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Fix secrects injection in GitHub Actions

Browse source
This commit is contained in:
Mingshen Sun 2023-03-18 20:51:50 -07:00
parent 5b73707033
commit 45acc2d9ab
2 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/deploying.yml vendored
View file

@ -59,6 +59,9 @@ jobs:
env: env:
APPLE_ID: ${{ secrets.APPLE_ID }} APPLE_ID: ${{ secrets.APPLE_ID }}
APP_IDENTIFIER: ${{ secrets.APP_IDENTIFIER }} APP_IDENTIFIER: ${{ secrets.APP_IDENTIFIER }}
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
APP_STORE_CONNECT_API_KEY_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_CONTENT }}
DESTINATION_EMAIL: ${{ secrets.DESTINATION_EMAIL }} DESTINATION_EMAIL: ${{ secrets.DESTINATION_EMAIL }}
EMAIL_FROM_NAME: ${{ secrets.EMAIL_FROM_NAME }} EMAIL_FROM_NAME: ${{ secrets.EMAIL_FROM_NAME }}
EMAIL_REPLY_TO: ${{ secrets.EMAIL_REPLY_TO }} EMAIL_REPLY_TO: ${{ secrets.EMAIL_REPLY_TO }}

15
fastlane/Fastfile
View file

@ -1,9 +1,4 @@
default_platform :ios default_platform :ios
api_key = app_store_connect_api_key(
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"],
)
lane :prepare do lane :prepare do
carthage(cache_builds: true, platform: "iOS") carthage(cache_builds: true, platform: "iOS")
@ -75,6 +70,11 @@ platform :ios do
desc "This will also make sure the profile is up to date" desc "This will also make sure the profile is up to date"
lane :beta do lane :beta do
app_identifier = "me.mssun.passforiosbeta" app_identifier = "me.mssun.passforiosbeta"
api_key = app_store_connect_api_key(
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"]
)
if is_ci? if is_ci?
create_keychain( create_keychain(
@ -129,6 +129,11 @@ platform :ios do
desc "Submit a new build to AppStore" desc "Submit a new build to AppStore"
lane :release do lane :release do
app_identifier = "me.mssun.passforios" app_identifier = "me.mssun.passforios"
api_key = app_store_connect_api_key(
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"]
)
if is_ci? if is_ci?
create_keychain( create_keychain(