lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

remove irrelevant properties from mocks

Browse source
This commit is contained in:
Lysann Tranvouez 2026-03-11 16:15:49 +01:00
parent 9e3e3d1134
commit 4e19d9e714
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
passKitTests/LowLevel/PGPAgentLowLevelTests.swift
View file

@ -71,7 +71,6 @@ final class PGPAgentLowLevelTests: XCTestCase {
func testDecryptWithKeyID_keyNotFound_throws() { func testDecryptWithKeyID_keyNotFound_throws() {
mockPGP.privateKeyIDs = [] mockPGP.privateKeyIDs = []
mockPGP.keyIDs = ["4712286271220db299883ea7062e678da1024dae", "787eae1a5fa3e749aa34cc6aa0645ebed862027e"]
XCTAssertThrowsError(try agent.decrypt(encryptedData: testEncryptedData, keyID: "UNKNOWN", requestPGPKeyPassphrase: passphraseCallback("pass"))) { error in XCTAssertThrowsError(try agent.decrypt(encryptedData: testEncryptedData, keyID: "UNKNOWN", requestPGPKeyPassphrase: passphraseCallback("pass"))) { error in
XCTAssertEqual(error as? AppError, AppError.pgpPrivateKeyNotFound(keyID: "UNKNOWN")) XCTAssertEqual(error as? AppError, AppError.pgpPrivateKeyNotFound(keyID: "UNKNOWN"))
@ -368,7 +367,6 @@ final class PGPAgentLowLevelTests: XCTestCase {
func testDecryptWithKeyID_keyNotFound_doesNotChangeDecryptStatus() throws { func testDecryptWithKeyID_keyNotFound_doesNotChangeDecryptStatus() throws {
let longFingerprint = "4712286271220db299883ea7062e678da1024dae" let longFingerprint = "4712286271220db299883ea7062e678da1024dae"
mockPGP.privateKeyIDs = [] mockPGP.privateKeyIDs = []
mockPGP.keyIDs = [longFingerprint, "787eae1a5fa3e749aa34cc6aa0645ebed862027e"]
// This throws pgpPrivateKeyNotFound without changing latestDecryptStatus. // This throws pgpPrivateKeyNotFound without changing latestDecryptStatus.
XCTAssertThrowsError(try agent.decrypt(encryptedData: testEncryptedData, keyID: "UNKNOWN", requestPGPKeyPassphrase: passphraseCallback("pass"))) XCTAssertThrowsError(try agent.decrypt(encryptedData: testEncryptedData, keyID: "UNKNOWN", requestPGPKeyPassphrase: passphraseCallback("pass")))
@ -444,7 +442,6 @@ final class PGPAgentLowLevelTests: XCTestCase {
let shortID = "a1024dae" let shortID = "a1024dae"
let longFingerprint = "4712286271220db299883ea7062e678da1024dae" let longFingerprint = "4712286271220db299883ea7062e678da1024dae"
mockPGP.privateKeyIDs = [longFingerprint] mockPGP.privateKeyIDs = [longFingerprint]
mockPGP.keyIDs = [longFingerprint]
_ = try agent.decrypt(encryptedData: testEncryptedData, keyID: shortID, requestPGPKeyPassphrase: passphraseCallback("pass")) _ = try agent.decrypt(encryptedData: testEncryptedData, keyID: shortID, requestPGPKeyPassphrase: passphraseCallback("pass"))
@ -457,7 +454,6 @@ final class PGPAgentLowLevelTests: XCTestCase {
let shortID = "a1024dae" let shortID = "a1024dae"
let longFingerprint = "4712286271220db299883ea7062e678da1024dae" let longFingerprint = "4712286271220db299883ea7062e678da1024dae"
mockPGP.privateKeyIDs = [longFingerprint] mockPGP.privateKeyIDs = [longFingerprint]
mockPGP.keyIDs = [longFingerprint]
mockPGP.selectedKeyForPassphrase = shortID mockPGP.selectedKeyForPassphrase = shortID
// Store passphrase under the LONG fingerprint. // Store passphrase under the LONG fingerprint.

6
passKitTests/Mocks/MockPGPInterface.swift
View file

@ -9,8 +9,6 @@ import Foundation
class MockPGPInterface: PGPInterface { class MockPGPInterface: PGPInterface {
// MARK: - Configuration // MARK: - Configuration
var keyIDs: [String] = []
var shortKeyIDs: [String] = []
var publicKeyIDs: Set<String> = [] var publicKeyIDs: Set<String> = []
var privateKeyIDs: Set<String> = [] var privateKeyIDs: Set<String> = []
@ -91,6 +89,6 @@ class MockPGPInterface: PGPInterface {
return privateKeyIDs.contains { $0.hasSuffix(keyID.lowercased()) } return privateKeyIDs.contains { $0.hasSuffix(keyID.lowercased()) }
} }
var keyID: [String] { keyIDs } var keyID: [String] { [] } // currently not relevant in these tests
var shortKeyID: [String] { shortKeyIDs } var shortKeyID: [String] { [] } // currently not relevant in these tests
} }