lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Keep SwiftLint rule 'prefixed_toplevel_constant' disabled

Browse source
This commit is contained in:
Danny Moesch 2020-07-05 22:46:21 +02:00 • committed by Mingshen Sun
parent f41fd7c551
commit 70d605e412
2 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.swiftlint.yml
View file

@ -124,7 +124,7 @@ whitelist_rules:
- override_in_extension - override_in_extension
- pattern_matching_keywords - pattern_matching_keywords
- prefer_self_type_over_type_of_self - prefer_self_type_over_type_of_self
# - prefixed_toplevel_constant # - prefixed_toplevel_constant # Violations are mostly in test code.
# - private_action # - private_action
# - private_outlet # - private_outlet
- private_over_fileprivate - private_over_fileprivate

10
pass/Controllers/PasswordsViewController.swift
View file

@ -10,9 +10,10 @@ import passKit
import SVProgressHUD import SVProgressHUD
import UIKit import UIKit
private let hideSectionHeaderThreshold = 6 // hide section header if passwords count is less than the threshold
class PasswordsViewController: UIViewController, UITableViewDataSource, UITableViewDelegate, UITabBarControllerDelegate, UISearchBarDelegate { class PasswordsViewController: UIViewController, UITableViewDataSource, UITableViewDelegate, UITabBarControllerDelegate, UISearchBarDelegate {
// Arbitrary threshold to decide whether to show folders or not for only a few entries.
private static let hideSectionHeaderThreshold = 6
private var passwordsTableEntries: [PasswordTableEntry] = [] private var passwordsTableEntries: [PasswordTableEntry] = []
private var passwordsTableAllEntries: [PasswordTableEntry] = [] private var passwordsTableAllEntries: [PasswordTableEntry] = []
private var parentPasswordEntity: PasswordEntity? private var parentPasswordEntity: PasswordEntity?
@ -437,10 +438,7 @@ class PasswordsViewController: UIViewController, UITableViewDataSource, UITableV
} }
private func hideSectionHeader() -> Bool { private func hideSectionHeader() -> Bool {
if passwordsTableEntries.count < hideSectionHeaderThreshold || searchController.isActive { return passwordsTableEntries.count < Self.hideSectionHeaderThreshold || searchController.isActive
return true
}
return false
} }
func tableView(_: UITableView, titleForHeaderInSection section: Int) -> String? { func tableView(_: UITableView, titleForHeaderInSection section: Int) -> String? {