From 95de38988b50fa834f73302463fe82255972bc8a Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Thu, 9 Feb 2017 15:58:32 +0800 Subject: [PATCH] polish code --- .../Controllers/OpenSourceComponentsTableViewController.swift | 4 +++- pass/Controllers/PasswordDetailTableViewController.swift | 4 +--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pass/Controllers/OpenSourceComponentsTableViewController.swift b/pass/Controllers/OpenSourceComponentsTableViewController.swift index 64558dc..102bad8 100644 --- a/pass/Controllers/OpenSourceComponentsTableViewController.swift +++ b/pass/Controllers/OpenSourceComponentsTableViewController.swift @@ -7,6 +7,7 @@ // import UIKit +import SafariServices class OpenSourceComponentsTableViewController: BasicStaticTableViewController { let openSourceComponents = [ @@ -43,7 +44,8 @@ class OpenSourceComponentsTableViewController: BasicStaticTableViewController { func actOnDetailDisclosureButton(_ sender: Any?) { if let link = sender as? String { - UIApplication.shared.open(URL(string: link)!, options: [:], completionHandler: nil) + let svc = SFSafariViewController(url: URL(string: link)!, entersReaderIfAvailable: false) + self.present(svc, animated: true, completion: nil) } } diff --git a/pass/Controllers/PasswordDetailTableViewController.swift b/pass/Controllers/PasswordDetailTableViewController.swift index 6cbbf3d..15f626c 100644 --- a/pass/Controllers/PasswordDetailTableViewController.swift +++ b/pass/Controllers/PasswordDetailTableViewController.swift @@ -42,9 +42,7 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni tableView.register(UINib(nibName: "LabelTableViewCell", bundle: nil), forCellReuseIdentifier: "labelCell") tableView.register(UINib(nibName: "PasswordDetailTitleTableViewCell", bundle: nil), forCellReuseIdentifier: "passwordDetailTitleTableViewCell") - let passwordCategoryArray = passwordCategoryEntities?.map({ (value: PasswordCategoryEntity) -> String in - value.category! - }) + let passwordCategoryArray = passwordCategoryEntities?.map { $0.category! } passwordCategoryText = (passwordCategoryArray?.joined(separator: " > "))! let tapGesture = UITapGestureRecognizer(target: self, action: #selector(PasswordDetailTableViewController.tapMenu(recognizer:)))