From 9a3131943f76299db9171511652a6e53f4d49e0a Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Sat, 17 Nov 2018 21:27:06 -0800 Subject: [PATCH] Cleanup unneccessary error handling in the updatePasswordImage function --- .../PasswordDetailTableViewController.swift | 27 ++++++------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/pass/Controllers/PasswordDetailTableViewController.swift b/pass/Controllers/PasswordDetailTableViewController.swift index 546d54e..146f6a8 100644 --- a/pass/Controllers/PasswordDetailTableViewController.swift +++ b/pass/Controllers/PasswordDetailTableViewController.swift @@ -322,27 +322,16 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni newUrlString = "https://\(urlString)" } - guard let url = URL(string: newUrlString) else { - return - } - - do { - try FavIcon.downloadPreferred(url) { [weak self] result in - switch result { - case .success(let image): - let indexPath = IndexPath(row: 0, section: 0) - self?.passwordImage = image - self?.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic) - let imageData = UIImageJPEGRepresentation(image, 1) - if let entity = self?.passwordEntity { - self?.passwordStore.updateImage(passwordEntity: entity, image: imageData) - } - case .failure(let error): - print(error) + try? FavIcon.downloadPreferred(newUrlString) { [weak self] result in + if case let .success(image) = result { + let indexPath = IndexPath(row: 0, section: 0) + self?.passwordImage = image + self?.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic) + let imageData = UIImageJPEGRepresentation(image, 1) + if let entity = self?.passwordEntity { + self?.passwordStore.updateImage(passwordEntity: entity, image: imageData) } } - } catch { - print(error) } }