From c0edb7d3361600138642d54494afa2d00d6d30e1 Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Thu, 9 Feb 2017 13:33:50 +0800 Subject: [PATCH] weak self --- .../PasswordDetailTableViewController.swift | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/pass/Controllers/PasswordDetailTableViewController.swift b/pass/Controllers/PasswordDetailTableViewController.swift index 4b20d0e..3b0ac9e 100644 --- a/pass/Controllers/PasswordDetailTableViewController.swift +++ b/pass/Controllers/PasswordDetailTableViewController.swift @@ -86,12 +86,12 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni } } } - DispatchQueue.main.async { - self.tableView.reloadData() + DispatchQueue.main.async { [weak self] in + self?.tableView.reloadData() indicator.stopAnimating() indicatorLable.isHidden = true - if self.password.url != "" { - self.updatePasswordImage(url: self.password.url) + if self?.password.url != "" { + self?.updatePasswordImage(url: self?.password.url ?? "") } } } @@ -99,12 +99,14 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni func updatePasswordImage(url: String) { do { - try FavIcon.downloadPreferred(url) { result in + print("downloading: \(url)") + try FavIcon.downloadPreferred(url) { [weak self] result in switch result { case .success(let image): let indexPath = IndexPath(row: 0, section: 0) - self.passwordImage = image - self.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic) + self?.passwordImage = image + self?.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic) + print("success") case .failure(let error): print(error) }