lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Use XCTAssert instead of XCTAssertTrue

Browse source
This commit is contained in:
Danny Moesch 2018-12-15 21:51:22 +01:00 • committed by Bob Sun
parent ae57042f36
commit c18b70e7d7
4 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

6
passKitTests/Models/PasswordTest.swift
View file

@ -35,7 +35,7 @@ class PasswordTest: XCTestCase {
XCTAssertEqual(password.password, "") XCTAssertEqual(password.password, "")
XCTAssertEqual(password.plainData, fileContent.data(using: .utf8)) XCTAssertEqual(password.plainData, fileContent.data(using: .utf8))
XCTAssertEqual(password.additionsPlainText, "") XCTAssertEqual(password.additionsPlainText, "")
XCTAssertTrue(password.getFilteredAdditions().isEmpty) XCTAssert(password.getFilteredAdditions().isEmpty)
XCTAssertEqual(password.numberOfUnknowns, 0) XCTAssertEqual(password.numberOfUnknowns, 0)
XCTAssertNil(password.username) XCTAssertNil(password.username)
@ -224,7 +224,7 @@ class PasswordTest: XCTestCase {
XCTAssertEqual(password.password, fileContent) XCTAssertEqual(password.password, fileContent)
XCTAssertEqual(password.plainData, fileContent.data(using: .utf8)) XCTAssertEqual(password.plainData, fileContent.data(using: .utf8))
XCTAssertTrue(password.additionsPlainText.isEmpty) XCTAssert(password.additionsPlainText.isEmpty)
XCTAssertEqual(password.numberOfUnknowns, 0) XCTAssertEqual(password.numberOfUnknowns, 0)
XCTAssertEqual(password.numberOfOtpRelated, 0) XCTAssertEqual(password.numberOfOtpRelated, 0)
@ -306,7 +306,7 @@ class PasswordTest: XCTestCase {
let otpStrings = password.getOtpStrings() let otpStrings = password.getOtpStrings()
XCTAssertNotNil(otpStrings) XCTAssertNotNil(otpStrings)
XCTAssertTrue(otpStrings!.description.hasPrefix("time-based (expires in")) XCTAssert(otpStrings!.description.hasPrefix("time-based (expires in"))
} }
func testOtpStringsHotpToken() { func testOtpStringsHotpToken() {

6
passKitTests/Parser/AdditionFieldTest.swift
View file

@ -21,9 +21,9 @@ class AdditionFieldTest: XCTestCase {
XCTAssertEqual(field2.asString, "no content: ") XCTAssertEqual(field2.asString, "no content: ")
XCTAssertEqual(field3.asString, "no title") XCTAssertEqual(field3.asString, "no title")
XCTAssertTrue(field1.asTuple == ("key", "value")) XCTAssert(field1.asTuple == ("key", "value"))
XCTAssertTrue(field2.asTuple == ("no content", "")) XCTAssert(field2.asTuple == ("no content", ""))
XCTAssertTrue(field3.asTuple == ("", "no title")) XCTAssert(field3.asTuple == ("", "no title"))
} }
func testAdditionFieldEquals() { func testAdditionFieldEquals() {

12
passKitTests/Parser/ConstantsTest.swift
View file

@ -13,22 +13,22 @@ import XCTest
class ConstantsTest: XCTestCase { class ConstantsTest: XCTestCase {
func testIsOtpRelated() { func testIsOtpRelated() {
XCTAssertTrue(Constants.isOtpRelated(line: "otpauth://something")) XCTAssert(Constants.isOtpRelated(line: "otpauth://something"))
XCTAssertTrue(Constants.isOtpRelated(line: "otp_algorithm: algorithm")) XCTAssert(Constants.isOtpRelated(line: "otp_algorithm: algorithm"))
XCTAssertFalse(Constants.isOtpRelated(line: "otp: something")) XCTAssertFalse(Constants.isOtpRelated(line: "otp: something"))
XCTAssertFalse(Constants.isOtpRelated(line: "otp")) XCTAssertFalse(Constants.isOtpRelated(line: "otp"))
} }
func testIsOtpKeyword() { func testIsOtpKeyword() {
XCTAssertTrue(Constants.isOtpKeyword("otpauth")) XCTAssert(Constants.isOtpKeyword("otpauth"))
XCTAssertTrue(Constants.isOtpKeyword("oTP_DigITS")) XCTAssert(Constants.isOtpKeyword("oTP_DigITS"))
XCTAssertFalse(Constants.isOtpKeyword("otp")) XCTAssertFalse(Constants.isOtpKeyword("otp"))
XCTAssertFalse(Constants.isOtpKeyword("no keyword")) XCTAssertFalse(Constants.isOtpKeyword("no keyword"))
} }
func testIsUnknown() { func testIsUnknown() {
XCTAssertTrue(Constants.isUnknown("unknown")) XCTAssert(Constants.isUnknown("unknown"))
XCTAssertTrue(Constants.isUnknown("unknown string")) XCTAssert(Constants.isUnknown("unknown string"))
XCTAssertFalse(Constants.isUnknown("otp")) XCTAssertFalse(Constants.isUnknown("otp"))
XCTAssertFalse(Constants.isUnknown("Unknown")) XCTAssertFalse(Constants.isUnknown("Unknown"))
} }

12
passKitTests/Parser/ParserTest.swift
View file

@ -28,12 +28,12 @@ class ParserTest: XCTestCase {
} }
func testGetKeyValuePair() { func testGetKeyValuePair() {
XCTAssertTrue(Parser.getKeyValuePair(from: "key: value") == ("key", "value")) XCTAssert(Parser.getKeyValuePair(from: "key: value") == ("key", "value"))
XCTAssertTrue(Parser.getKeyValuePair(from: "a key: a value") == ("a key", "a value")) XCTAssert(Parser.getKeyValuePair(from: "a key: a value") == ("a key", "a value"))
XCTAssertTrue(Parser.getKeyValuePair(from: "key:value") == (nil, "key:value")) XCTAssert(Parser.getKeyValuePair(from: "key:value") == (nil, "key:value"))
XCTAssertTrue(Parser.getKeyValuePair(from: ": value") == (nil, "value")) XCTAssert(Parser.getKeyValuePair(from: ": value") == (nil, "value"))
XCTAssertTrue(Parser.getKeyValuePair(from: "key: ") == ("key", "")) XCTAssert(Parser.getKeyValuePair(from: "key: ") == ("key", ""))
XCTAssertTrue(Parser.getKeyValuePair(from: "otpauth://value") == ("otpauth", "otpauth://value")) XCTAssert(Parser.getKeyValuePair(from: "otpauth://value") == ("otpauth", "otpauth://value"))
} }
func testEmptyFiles() { func testEmptyFiles() {