From d6c7b67fcc313642e0115193e41a2f0fb2fbce24 Mon Sep 17 00:00:00 2001
From: Bob Sun <bob@mssun.me>
Date: Tue, 25 Apr 2017 20:13:59 -0700
Subject: [PATCH] Fix issue about remembering passphrase function (#74)

---
 .../PGPKeyArmorSettingTableViewController.swift            | 1 +
 pass/Controllers/SettingsTableViewController.swift         | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/pass/Controllers/PGPKeyArmorSettingTableViewController.swift b/pass/Controllers/PGPKeyArmorSettingTableViewController.swift
index 34f7649..16b7fd0 100644
--- a/pass/Controllers/PGPKeyArmorSettingTableViewController.swift
+++ b/pass/Controllers/PGPKeyArmorSettingTableViewController.swift
@@ -28,6 +28,7 @@ class PGPKeyArmorSettingTableViewController: UITableViewController, UITextViewDe
         let savePassphraseAlert = UIAlertController(title: "Passphrase", message: "Do you want to save the passphrase for later decryption?", preferredStyle: UIAlertControllerStyle.alert)
         savePassphraseAlert.addAction(UIAlertAction(title: "No", style: UIAlertActionStyle.default) { _ in
             Defaults[.isRememberPassphraseOn] = false
+            self.pgpPassphrase = nil
             self.performSegue(withIdentifier: "savePGPKeySegue", sender: self)
         })
         savePassphraseAlert.addAction(UIAlertAction(title: "Save", style: UIAlertActionStyle.destructive) {_ in
diff --git a/pass/Controllers/SettingsTableViewController.swift b/pass/Controllers/SettingsTableViewController.swift
index 2f70ea2..5ffb1e1 100644
--- a/pass/Controllers/SettingsTableViewController.swift
+++ b/pass/Controllers/SettingsTableViewController.swift
@@ -34,7 +34,9 @@ class SettingsTableViewController: UITableViewController {
         if let controller = segue.source as? PGPKeySettingTableViewController {
             Defaults[.pgpPrivateKeyURL] = URL(string: controller.pgpPrivateKeyURLTextField.text!)
             Defaults[.pgpPublicKeyURL] = URL(string: controller.pgpPublicKeyURLTextField.text!)
-            self.passwordStore.pgpKeyPassphrase = controller.pgpPassphrase
+            if Defaults[.isRememberPassphraseOn] {
+                self.passwordStore.pgpKeyPassphrase = controller.pgpPassphrase
+            }
             Defaults[.pgpKeySource] = "url"
             
             SVProgressHUD.setDefaultMaskType(.black)
@@ -60,9 +62,8 @@ class SettingsTableViewController: UITableViewController {
             
         } else if let controller = segue.source as? PGPKeyArmorSettingTableViewController {
             Defaults[.pgpKeySource] = "armor"
-            self.passwordStore.pgpKeyPassphrase = controller.pgpPassphrase
             if Defaults[.isRememberPassphraseOn] {
-                Utils.addPasswordToKeychain(name: "pgpKeyPassphrase", password: controller.pgpPassphrase!)
+                self.passwordStore.pgpKeyPassphrase = controller.pgpPassphrase
             }
 
             Defaults[.pgpPublicKeyArmor] = controller.armorPublicKeyTextView.text!