From e1cb280d4abcb222cfe2d6367c1763261c8679d8 Mon Sep 17 00:00:00 2001 From: Danny Moesch Date: Sun, 5 Jul 2020 23:47:33 +0200 Subject: [PATCH] Enable SwiftLint rule 'weak_delegate' and fix all violations --- .swiftlint.yml | 2 +- pass/Controllers/QRScannerController.swift | 2 +- pass/Views/FillPasswordTableViewCell.swift | 4 ++-- pass/Views/SliderTableViewCell.swift | 2 +- pass/Views/SwitchTableViewCell.swift | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index ec45fe4..7d1dd80 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -192,7 +192,7 @@ whitelist_rules: - vertical_whitespace_closing_braces - vertical_whitespace_opening_braces - void_return -# - weak_delegate + - weak_delegate - xct_specific_matcher - xctfail_message - yoda_condition diff --git a/pass/Controllers/QRScannerController.swift b/pass/Controllers/QRScannerController.swift index 0ce7101..c18ddeb 100644 --- a/pass/Controllers/QRScannerController.swift +++ b/pass/Controllers/QRScannerController.swift @@ -26,7 +26,7 @@ class QRScannerController: UIViewController, AVCaptureMetadataOutputObjectsDeleg let supportedCodeTypes = [AVMetadataObject.ObjectType.qr] - var delegate: QRScannerControllerDelegate? + weak var delegate: QRScannerControllerDelegate? override func viewDidLoad() { super.viewDidLoad() diff --git a/pass/Views/FillPasswordTableViewCell.swift b/pass/Views/FillPasswordTableViewCell.swift index d680987..70b94f0 100644 --- a/pass/Views/FillPasswordTableViewCell.swift +++ b/pass/Views/FillPasswordTableViewCell.swift @@ -16,11 +16,11 @@ protocol FillPasswordTableViewCellDelegate: AnyObject { class FillPasswordTableViewCell: UITableViewCell, ContentProvider { @IBOutlet var contentTextField: UITextField! - var delegate: FillPasswordTableViewCellDelegate? - @IBOutlet var settingButton: UIButton! @IBOutlet var generateButton: UIButton! + weak var delegate: FillPasswordTableViewCellDelegate? + override func awakeFromNib() { super.awakeFromNib() // Initialization code diff --git a/pass/Views/SliderTableViewCell.swift b/pass/Views/SliderTableViewCell.swift index b1762f7..4e2034e 100644 --- a/pass/Views/SliderTableViewCell.swift +++ b/pass/Views/SliderTableViewCell.swift @@ -17,7 +17,7 @@ class SliderTableViewCell: UITableViewCell { private var checker: ((Int) -> Bool)! private var updater: ((Int) -> Void)! - private var delegate: PasswordSettingSliderTableViewCellDelegate! + private weak var delegate: PasswordSettingSliderTableViewCellDelegate! @IBAction private func handleSliderValueChange(_ sender: UISlider) { diff --git a/pass/Views/SwitchTableViewCell.swift b/pass/Views/SwitchTableViewCell.swift index e0314c3..a5fc5ea 100644 --- a/pass/Views/SwitchTableViewCell.swift +++ b/pass/Views/SwitchTableViewCell.swift @@ -15,7 +15,7 @@ class SwitchTableViewCell: UITableViewCell { private var updater: ((Bool) -> Void)! - private var delegate: PasswordSettingSliderTableViewCellDelegate! + private weak var delegate: PasswordSettingSliderTableViewCellDelegate! @IBAction private func switchValueChanged(_: Any) {