From e418d216b998f14288a0554b8bffb7f000839a66 Mon Sep 17 00:00:00 2001 From: Danny Moesch Date: Sun, 10 Nov 2019 18:28:14 +0100 Subject: [PATCH] Fix #324: Do not copy password automatically when adding/editing it --- pass/Controllers/PasswordEditorTableViewController.swift | 4 ---- pass/de.lproj/Localizable.strings | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pass/Controllers/PasswordEditorTableViewController.swift b/pass/Controllers/PasswordEditorTableViewController.swift index d0aca9b..5bd2d52 100644 --- a/pass/Controllers/PasswordEditorTableViewController.swift +++ b/pass/Controllers/PasswordEditorTableViewController.swift @@ -204,7 +204,6 @@ class PasswordEditorTableViewController: UITableViewController, FillPasswordTabl let length = passwordLengthCell?.roundedValue ?? 0 let plainPassword = PasswordGeneratorFlavour.from(SharedDefaults[.passwordGeneratorFlavor]).generatePassword(length: length) - SecurePasteboard.shared.copy(textToCopy: plainPassword) // update tableData so to make sure reloadData() works correctly tableData[passwordSection][0][PasswordEditorCellKey.content] = plainPassword @@ -274,7 +273,6 @@ class PasswordEditorTableViewController: UITableViewController, FillPasswordTabl } else if textField == fillPasswordCell?.contentTextField { if let plainPassword = fillPasswordCell?.getContent() { tableData[passwordSection][0][PasswordEditorCellKey.content] = plainPassword - SecurePasteboard.shared.copy(textToCopy: plainPassword) } } } @@ -347,8 +345,6 @@ class PasswordEditorTableViewController: UITableViewController, FillPasswordTabl self.tableData[self.passwordSection][0][PasswordEditorCellKey.content] = generatedPassword // update cell manually, no need to call reloadData() self.fillPasswordCell?.setContent(content: generatedPassword) - // make sure the clipboard gets cleared in 45s - SecurePasteboard.shared.copy(textToCopy: generatedPassword) })) alert.addAction(UIAlertAction(title: "Cancel".localize(), style: UIAlertAction.Style.cancel, handler:nil)) self.present(alert, animated: true, completion: nil) diff --git a/pass/de.lproj/Localizable.strings b/pass/de.lproj/Localizable.strings index e065a19..880dba7 100644 --- a/pass/de.lproj/Localizable.strings +++ b/pass/de.lproj/Localizable.strings @@ -256,7 +256,7 @@ "RemovePrefix." = "Bitte entferne den Prefix \"/\" vom Namen des Passwortes."; "PasswordNameInvalid." = "Der Name des Passwortes ist ungültig."; "CannotParseFilename." = "Der Name der Datei kann nicht gelesen werden. Bitte vereinfache den Namen des Passwortes."; -"WannaUseIt?" = "Möchtest du es benutzen?"; +"WannaUseIt?" = "Möchtest du es als Passwort verwenden?"; "SeemsLikeYouHaveCopiedSomething." = "Scheint so, als hast du etwas kopiert."; "FirstStringIs:" = "Die erste Zeichenkette ist:";