From e4e20b1d6f7d32e607deda0eced16cd7b81f5353 Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Tue, 21 Mar 2017 23:05:52 -0700 Subject: [PATCH] Polish code of GitServerSettingTableViewController --- .../GitServerSettingTableViewController.swift | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/pass/Controllers/GitServerSettingTableViewController.swift b/pass/Controllers/GitServerSettingTableViewController.swift index 21e29a0..3f940d5 100644 --- a/pass/Controllers/GitServerSettingTableViewController.swift +++ b/pass/Controllers/GitServerSettingTableViewController.swift @@ -77,15 +77,12 @@ class GitServerSettingTableViewController: UITableViewController { override func shouldPerformSegue(withIdentifier identifier: String, sender: Any?) -> Bool { if identifier == "saveGitServerSettingSegue" { - if gitRepositoryURLTextField.text == "" || authenticationMethod == nil { - var alertMessage = "" - if gitRepositoryURLTextField.text == "" { - alertMessage = "Git Server is not set. Please set the Git server first." - } - if authenticationMethod == nil { - alertMessage = "Authentication method is not set. Please set your authentication method first." - } - Utils.alert(title: "Cannot Save Settings", message: alertMessage, controller: self, completion: nil) + guard let _ = URL(string: gitRepositoryURLTextField.text!) else { + Utils.alert(title: "Cannot Save", message: "Git Server is not set.", controller: self, completion: nil) + return false + } + guard authenticationMethod != nil else { + Utils.alert(title: "Cannot Save", message: "Authentication method is not set.", controller: self, completion: nil) return false } }