lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Make 'isUnknown' method more precise

Browse source
This commit is contained in:
Danny Moesch 2019-01-26 16:26:53 +01:00 • committed by Mingshen Sun
parent a2edf41d33
commit e8afd251ed
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
passKit/Parser/Constants.swift
View file

@ -58,7 +58,8 @@ public struct Constants {
} }
static func isUnknown(_ string: String) -> Bool { static func isUnknown(_ string: String) -> Bool {
return string.starts(with: UNKNOWN) let components = string.components(separatedBy: " ")
return components.count == 2 && components[0] == UNKNOWN && UInt(components[1]) != nil
} }
static func unknown(_ number: UInt) -> String { static func unknown(_ number: UInt) -> String {

9
passKitTests/Parser/ConstantsTest.swift
View file

@ -27,10 +27,13 @@ class ConstantsTest: XCTestCase {
} }
func testIsUnknown() { func testIsUnknown() {
XCTAssert(Constants.isUnknown("unknown")) XCTAssert(Constants.isUnknown("unknown 1"))
XCTAssert(Constants.isUnknown("unknown string")) XCTAssert(Constants.isUnknown("unknown 435"))
XCTAssertFalse(Constants.isUnknown("otp")) XCTAssertFalse(Constants.isUnknown("otp"))
XCTAssertFalse(Constants.isUnknown("Unknown")) XCTAssertFalse(Constants.isUnknown("unknown "))
XCTAssertFalse(Constants.isUnknown("unknown something"))
XCTAssertFalse(Constants.isUnknown("unknown 123 something"))
XCTAssertFalse(Constants.isUnknown("Unknown 1"))
} }
func testUnknown() { func testUnknown() {