Fix bugs may introduce crashes

This commit is contained in:
Bob Sun 2017-04-23 10:16:50 -07:00
parent 914f072ab2
commit ee077bf026
No known key found for this signature in database
GPG key ID: 1F86BA2052FED3B4

View file

@ -71,7 +71,7 @@ struct GitCredential {
let encrypted = try? String(contentsOf: privateKeyFile).contains("ENCRYPTED")
// Request password if not already set
if encrypted! && password == "" {
if encrypted == nil && password == "" {
newPassword = passwordNotSetCallback!()
}
@ -112,8 +112,8 @@ class PasswordStore {
var gitSignatureForNow: GTSignature {
get {
let name = Defaults[.gitName] ?? Defaults[.gitUsername]!
let email = Defaults[.gitEmail] ?? (Defaults[.gitUsername]!+"@passforios")
let name = Defaults[.gitName] ?? Defaults[.gitUsername] ?? ""
let email = Defaults[.gitEmail] ?? (Defaults[.gitUsername] ?? "" + "@passforios")
return GTSignature(name: name, email: email, time: Date())!
}
}
@ -184,11 +184,11 @@ class PasswordStore {
public func initGitCredential() {
if Defaults[.gitAuthenticationMethod] == "Password" {
gitCredential = GitCredential(credential: GitCredential.Credential.http(userName: Defaults[.gitUsername]!, password: Utils.getPasswordFromKeychain(name: "gitPassword") ?? ""))
gitCredential = GitCredential(credential: GitCredential.Credential.http(userName: Defaults[.gitUsername] ?? "", password: Utils.getPasswordFromKeychain(name: "gitPassword") ?? ""))
} else if Defaults[.gitAuthenticationMethod] == "SSH Key"{
gitCredential = GitCredential(
credential: GitCredential.Credential.ssh(
userName: Defaults[.gitUsername]!,
userName: Defaults[.gitUsername] ?? "",
password: gitSSHPrivateKeyPassphrase ?? "",
publicKeyFile: Globals.gitSSHPublicKeyURL,
privateKeyFile: Globals.gitSSHPrivateKeyURL,