lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Support hiding one time password related fields.

Browse source 
- Add a switch to turn on/off one time password related fields.
- Improve how we show the additional information
This commit is contained in:
Yishi Lin 2017-03-03 17:12:25 +08:00
parent 3dac155d6c
commit f2edc2ffaa
4 changed files with 76 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

30
pass/Controllers/PasswordDetailTableViewController.swift
View file

@ -199,20 +199,7 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni
self.tableData[tableDataIndex].item.append(TableCell(title: "username", content: username))
}
self.tableData[tableDataIndex].item.append(TableCell(title: "password", content: password.password))
// Show additional information
if password.additions.count > 0 {
self.tableData.append(TableSection(title: "additions", item: []))
tableDataIndex += 1
for additionKey in password.additionKeys {
if (!additionKey.hasPrefix("unknown") || !Defaults[.isHideUnknownOn]) &&
additionKey.lowercased() != "username" &&
additionKey.lowercased() != "password" {
self.tableData[tableDataIndex].item.append(TableCell(title: additionKey, content: password.additions[additionKey]!))
}
}
}
// Show one time password
if password.otpType == "totp", password.otpToken != nil {
self.tableData.append(TableSection(title: "One time password (TOTP)", item: []))
@ -221,6 +208,21 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni
self.tableData[tableDataIndex].item.append(TableCell(title: "current", content: crtPassword))
}
}
// Show additional information
let filteredAdditionKeys = password.additionKeys.filter {
$0.lowercased() != "username" &&
$0.lowercased() != "password" &&
(!$0.hasPrefix("unknown") || !Defaults[.isHideOTPOn]) &&
(!Password.otpKeywords.contains($0) || !Defaults[.isHideOTPOn]) }
if filteredAdditionKeys.count > 0 {
self.tableData.append(TableSection(title: "additions", item: []))
tableDataIndex += 1
for additionKey in filteredAdditionKeys {
self.tableData[tableDataIndex].item.append(TableCell(title: additionKey, content: password.additions[additionKey]!))
}
}
}
override func prepare(for segue: UIStoryboardSegue, sender: Any?) {