From 5c7ccc5b3742c7ff2462feb6302f54e27ec11bc1 Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Sat, 7 Oct 2017 10:42:09 -0700 Subject: [PATCH 01/10] Never use large titles in password details --- pass/Controllers/PasswordDetailTableViewController.swift | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pass/Controllers/PasswordDetailTableViewController.swift b/pass/Controllers/PasswordDetailTableViewController.swift index 14d9a4a..41d5f80 100644 --- a/pass/Controllers/PasswordDetailTableViewController.swift +++ b/pass/Controllers/PasswordDetailTableViewController.swift @@ -89,6 +89,9 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni tableView.addSubview(indicator) editUIBarButtonItem.isEnabled = false navigationItem.rightBarButtonItem = editUIBarButtonItem + if #available(iOS 11.0, *) { + navigationItem.largeTitleDisplayMode = .never + } if let imageData = passwordEntity?.image { let image = UIImage(data: imageData as Data) From 3f3360259af167ac704faa34ba20edadeb42df4d Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Sat, 7 Oct 2017 19:58:46 -0700 Subject: [PATCH 02/10] Optimize the top margin of raw password --- pass/Base.lproj/Main.storyboard | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pass/Base.lproj/Main.storyboard b/pass/Base.lproj/Main.storyboard index 413a892..19d4523 100644 --- a/pass/Base.lproj/Main.storyboard +++ b/pass/Base.lproj/Main.storyboard @@ -838,7 +838,7 @@ - + K7PBbkoaJf6mLyVX3EBU username: passforios-demo@email.com @@ -853,8 +853,8 @@ Phone Support PIN #: 84719 - + @@ -1805,7 +1805,7 @@ Cgo - + From be76987758f64666d9c1b8cf05486778c03668e7 Mon Sep 17 00:00:00 2001 From: Bob Sun Date: Sat, 7 Oct 2017 20:51:13 -0700 Subject: [PATCH 03/10] Fix UI constraint warning --- pass/Base.lproj/Main.storyboard | 2 +- pass/Views/FillPasswordTableViewCell.xib | 17 +++++++---------- pass/Views/LabelTableViewCell.xib | 11 +++++------ pass/Views/TextFieldTableViewCell.xib | 8 ++++---- pass/Views/TextViewTableViewCell.xib | 13 +++++++++---- 5 files changed, 26 insertions(+), 25 deletions(-) diff --git a/pass/Base.lproj/Main.storyboard b/pass/Base.lproj/Main.storyboard index 19d4523..1cd7a3c 100644 --- a/pass/Base.lproj/Main.storyboard +++ b/pass/Base.lproj/Main.storyboard @@ -1806,6 +1806,6 @@ Cgo - + diff --git a/pass/Views/FillPasswordTableViewCell.xib b/pass/Views/FillPasswordTableViewCell.xib index 715a3d3..2ebed2b 100644 --- a/pass/Views/FillPasswordTableViewCell.xib +++ b/pass/Views/FillPasswordTableViewCell.xib @@ -1,11 +1,11 @@ - + - + @@ -16,17 +16,14 @@ - + - + - - - - + @@ -35,7 +32,7 @@