Danny Mösch
d9bd0f3014
Update SwiftLint and SwiftFormat ( #613 )
...
* Update Swift version used by SwiftFormat
* Update SwiftLint version
* Rely on new virtual 'all' rule in SwiftLint
* Enable SwiftLint rule 'direct_return' rule and fix all violations
* Enable SwiftLint rule 'shorthand_optional_binding' rule and fix all violations
* Enable SwiftLint rule 'blanket_disable_command' rule and fix all violations
2023-04-23 13:01:37 -07:00
Danny Mösch
ad105b3df1
Enable some more SwitfLint rules ( #565 )
2022-06-15 19:55:02 -07:00
Mingshen Sun
9b5b0eff1f
Exclude the vendor dir for swiftformat and swiftlint ( #562 )
2022-05-23 15:27:58 -07:00
Danny Moesch
aad23582f9
Update SwiftLint to version 0.45.x ( #522 )
...
* Use SwiftLint version 0.45.x
* Enable SwiftLint rule 'self_in_property_initialization' and handle all violations
2021-12-27 14:58:02 -08:00
Danny Moesch
03c4fcc7b7
Add new SwiftLint rules
2021-10-07 19:49:19 +02:00
Danny Moesch
b7e08dfb9e
Enable SwiftLint rule 'static_operator' and fix all violations
2021-10-07 19:48:57 +02:00
Danny Mösch
82eb13f43c
Update SwiftLint to version 0.44.0 ( #507 )
2021-09-15 17:43:14 -07:00
Danny Moesch
bc2d9aa8e8
Present lock view only if needed for an action
...
* Do not present lock view in 'viewDidLoad' since this might be too early for an extension ("Not running foreground").
* Instead, show it for actions requiring authentication, e.g. showing the password list or providing a password, or only in 'viewDidAppear'.
* Refactor and lazily load other view controllers and data.
* Let credential providing view controllers decide when to hide themselves.
2021-08-27 22:03:00 -07:00
Danny Moesch
3f75591484
Use SwiftLint version 0.43.x
2021-03-07 16:42:08 -08:00
Danny Moesch
a49f0ee5e0
Use SwiftLint version 0.42.x
2020-12-23 19:59:26 -08:00
Danny Moesch
bf3bb8d168
Use SwiftLint version 0.47.x
2020-11-10 14:03:12 -08:00
Danny Moesch
e8389eb262
Enable SwiftLint rule 'identifier_name' and handle all violations
2020-09-20 17:25:50 -07:00
Danny Moesch
50b2e0f088
Enable SwiftLint rule 'implicit_return' and fix violation
2020-09-20 17:25:50 -07:00
Danny Moesch
b4d1b4de29
Enable SwiftLint rule 'function_parameter_count'
2020-09-20 17:25:50 -07:00
Danny Moesch
2cdd0e2521
Enable SwiftLint rule 'cyclomatic_complexity' and fix violation which is reasonable
2020-09-20 17:25:50 -07:00
Danny Moesch
8345bb89a4
Enable SwiftLint rule 'attributes' and configure it to agree with SwiftFormat
2020-09-20 17:25:50 -07:00
Danny Moesch
293df9ea6e
Enable SwiftLint rule 'trailing_comma'
2020-09-19 18:52:27 -07:00
Danny Moesch
f9d5d794f0
Fix new warning caused by Swift 5.3 and bring SwiftLint rule in sync with it
2020-09-19 18:52:27 -07:00
Danny Moesch
2b7b378e12
Polish SwiftLint and SwiftFormat configurations
2020-09-06 21:21:46 -07:00
Danny Moesch
8a4136b7ce
Enable SwiftLint rule 'computed_accessors_order' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
3197ef39a3
Use SwiftLint version 0.40.x
2020-08-28 16:42:30 -07:00
Danny Moesch
d3a11c9d29
Enable SwiftLint rule 'function_default_parameter_at_end' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
5270c92b76
Enable SwiftLint rule 'overridden_super_call' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
e1cb280d4a
Enable SwiftLint rule 'weak_delegate' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
c5e88d82c9
Enable SwiftLint rule 'vertical_whitespace_closing_braces' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
78be3dabe7
Keep SwiftLint rule 'vertical_whitespace_between_cases' disabled
2020-08-28 16:42:30 -07:00
Danny Moesch
f70114e8d7
Enable SwiftLint rule 'unused_optional_binding' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
ab80e5297e
Enable SwiftLint rule 'unneeded_parentheses_in_closure_argument' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
5cca2c30d8
Enable SwiftLint rule 'type_name' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
a0f6b2d039
Keep SwiftLint rule 'trailing_comma' disabled
2020-08-28 16:42:30 -07:00
Danny Moesch
0317f5a83b
Enable SwiftLint rule 'trailing_closure' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
937019d6e8
Enable SwiftLint rule 'toggle_bool' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
1b1bd46235
Enable SwiftLint rule 'switch_case_on_newline' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
79dbac4e9e
Enable SwiftLint rule 'strict_fileprivate' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
67301d64d3
Keep SwiftLint rule 'sorted_imports' disabled
2020-08-28 16:42:30 -07:00
Danny Moesch
b4551f83fb
Enable SwiftLint rule 'redundant_type_annotation' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
fe380d4d65
Enable SwiftLint rule 'private_action' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
70d605e412
Keep SwiftLint rule 'prefixed_toplevel_constant' disabled
2020-08-28 16:42:30 -07:00
Danny Moesch
f41fd7c551
Keep SwiftLint rule 'number_separator' disabled
2020-08-28 16:42:30 -07:00
Danny Moesch
b032ed2df3
Enable SwiftLint rule 'nslocalizedstring_require_bundle' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
92123448a4
Enable SwiftLint rule 'nslocalizedstring_key' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
77216abe14
Enable SwiftLint rule 'nesting' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
2920acefbc
Enable SwiftLint rule 'multiple_closures_with_trailing_closure' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
8828298afb
Enable SwiftLint rule 'multiline_parameters_brackets' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
959ef659d2
Enable SwiftLint rule 'multiline_parameters' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
55e2cd7939
Enable SwiftLint rule 'multiline_literal_brackets' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
776c813f94
Enable SwiftLint rule 'multiline_function_chains' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
c87f4e9792
Enable SwiftLint rule 'multiline_arguments_brackets' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
b4c25726a5
Enable SwiftLint rule 'lower_acl_than_parent' and fix all violations
2020-08-28 16:42:30 -07:00
Danny Moesch
1b3a8ff0d8
Enable SwiftLint rule 'let_var_whitespace' and fix all violations
2020-08-28 16:42:30 -07:00
