rasperrypi-home/hassio-plejd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix type-o in writeFailed error handling

Browse source
This commit is contained in:
Victor Hagelbäck 2021-02-11 22:45:13 +01:00
parent 853511a755
commit d133efe228
2 changed files with 24 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

19
plejd/MqttClient.js
View file

@ -123,14 +123,19 @@ class MqttClient extends EventEmitter {
const messageString = message.toString();
const isJsonMessage = messageString.startsWith('{');
const command = isJsonMessage
? JSON.parse(messageString)
: messageString;
const command = isJsonMessage ? JSON.parse(messageString) : messageString;
if (!isJsonMessage && messageString === 'ON' && this.deviceRegistry.getScene(decodedTopic.id)) {
if (
!isJsonMessage
&& messageString === 'ON'
&& this.deviceRegistry.getScene(decodedTopic.id)
) {
// Guess that id that got state command without dim value belongs to Scene, not Device
// This guess could very well be wrong depending on the installation...
logger.warn(`Device id ${decodedTopic.id} belongs to both scene and device, guessing Scene is what should be set to ON. OFF commands still sent to device.`);
logger.warn(
`Device id ${decodedTopic.id} belongs to both scene and device, guessing Scene is what should be set to ON.`
+ 'OFF commands still sent to device.',
);
device = this.deviceRegistry.getScene(decodedTopic.id);
}
const deviceName = device ? device.name : '';
@ -164,7 +169,9 @@ class MqttClient extends EventEmitter {
logger.verbose(`Warning: Unknown command ${decodedTopic.command} in decoded topic`);
}
} else {
logger.verbose(`Warning: Got unrecognized mqtt command on '${topic}': ${message.toString()}`);
logger.verbose(
`Warning: Got unrecognized mqtt command on '${topic}': ${message.toString()}`,
);
}
}
});