lysann/passforios
1
0
Fork 0
Code Issues Pull requests Activity

Cleanup unneccessary error handling in the updatePasswordImage function

Browse source
This commit is contained in:
Bob Sun 2018-11-17 21:27:06 -08:00
parent f0eb9c47ed
commit 9a3131943f
No known key found for this signature in database
GPG key ID: 1F86BA2052FED3B4
1 changed files with 8 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

27
pass/Controllers/PasswordDetailTableViewController.swift
View file

@ -322,27 +322,16 @@ class PasswordDetailTableViewController: UITableViewController, UIGestureRecogni
newUrlString = "https://\(urlString)"
}
guard let url = URL(string: newUrlString) else {
return
}
do {
try FavIcon.downloadPreferred(url) { [weak self] result in
switch result {
case .success(let image):
let indexPath = IndexPath(row: 0, section: 0)
self?.passwordImage = image
self?.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic)
let imageData = UIImageJPEGRepresentation(image, 1)
if let entity = self?.passwordEntity {
self?.passwordStore.updateImage(passwordEntity: entity, image: imageData)
}
case .failure(let error):
print(error)
try? FavIcon.downloadPreferred(newUrlString) { [weak self] result in
if case let .success(image) = result {
let indexPath = IndexPath(row: 0, section: 0)
self?.passwordImage = image
self?.tableView.reloadRows(at: [indexPath], with: UITableViewRowAnimation.automatic)
let imageData = UIImageJPEGRepresentation(image, 1)
if let entity = self?.passwordEntity {
self?.passwordStore.updateImage(passwordEntity: entity, image: imageData)
}
}
} catch {
print(error)
}
}