Present lock view only if needed for an action

* Do not present lock view in 'viewDidLoad' since this might be too early for an extension ("Not running foreground").
* Instead, show it for actions requiring authentication, e.g. showing the password list or providing a password, or only in 'viewDidAppear'.
* Refactor and lazily load other view controllers and data.
* Let credential providing view controllers decide when to hide themselves.

.swiftlint.yml

@@ -221,6 +221,8 @@ closure_body_length:
 identifier_name:
   excluded: ["id", "to", "Defaults"]
   allowed_symbols: ["_"]
+multiline_arguments:
+  only_enforce_after_first_closure_on_first_line: true
 type_name:
   max_length: 50
 trailing_closure:

passAutoFillExtension/Controllers/CredentialProviderViewController.swift

@@ -10,36 +10,44 @@ import AuthenticationServices
 import passKit
 
 class CredentialProviderViewController: ASCredentialProviderViewController {
-    var passcodelock: PasscodeExtensionDisplay {
+    private lazy var passcodelock: PasscodeExtensionDisplay = { [unowned self] in
         PasscodeExtensionDisplay(extensionContext: extensionContext)
-    }
+    }()
 
-    var embeddedNavigationController: UINavigationController {
+    private lazy var passwordsViewController: PasswordsViewController = {
-        children.first as! UINavigationController
+        (children.first as! UINavigationController).viewControllers.first as! PasswordsViewController
-    }
+    }()
 
-    var passwordsViewController: PasswordsViewController {
+    private lazy var credentialProvider: CredentialProvider = { [unowned self] in
-        embeddedNavigationController.viewControllers.first as! PasswordsViewController
+        CredentialProvider(viewController: self, extensionContext: extensionContext)
-    }
+    }()
 
-    lazy var credentialProvider = CredentialProvider(viewController: self, extensionContext: self.extensionContext)
+    private lazy var passwordsTableEntries = PasswordStore.shared.fetchPasswordEntityCoreData(withDir: false)
+        .map(PasswordTableEntry.init(_:))
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        passcodelock.presentPasscodeLockIfNeeded(self)
+        passwordsViewController.dataSource = PasswordsTableDataSource(entries: passwordsTableEntries)
-
-        let passwordsTableEntries = PasswordStore.shared.fetchPasswordEntityCoreData(withDir: false).compactMap { PasswordTableEntry($0) }
-        let dataSource = PasswordsTableDataSource(entries: passwordsTableEntries)
-        passwordsViewController.dataSource = dataSource
         passwordsViewController.selectionDelegate = self
-        passwordsViewController.navigationItem.leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: .cancel, target: self, action: #selector(cancel))
+        passwordsViewController.navigationItem.leftBarButtonItem = UIBarButtonItem(
+            barButtonSystemItem: .cancel,
+            target: self,
+            action: #selector(cancel)
+        )
     }
 
     override func prepareCredentialList(for serviceIdentifiers: [ASCredentialServiceIdentifier]) {
-        credentialProvider.identifier = serviceIdentifiers.first
+        passcodelock.presentPasscodeLockIfNeeded(self) {
-        let url = serviceIdentifiers.first.flatMap { URL(string: $0.identifier) }
+            self.view.isHidden = true
-        passwordsViewController.navigationItem.prompt = url?.host
+        } after: { [unowned self] in
-        passwordsViewController.showPasswordsWithSuggestion(matching: url?.host ?? "")
+            self.view.isHidden = false
+            self.credentialProvider.identifier = serviceIdentifiers.first
+            let url = serviceIdentifiers.first
+                .map(\.identifier)
+                .flatMap(URL.init(string:))
+            self.passwordsViewController.navigationItem.prompt = url?.host
+            self.passwordsViewController.showPasswordsWithSuggestion(matching: url?.host ?? "")
+        }
     }
 
     override func provideCredentialWithoutUserInteraction(for credentialIdentity: ASPasswordCredentialIdentity) {
@@ -55,9 +63,11 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
         guard let identifier = credentialIdentity.recordIdentifier else {
             return
         }
-        credentialProvider.identifier = credentialIdentity.serviceIdentifier
+        passcodelock.presentPasscodeLockIfNeeded(self, after: { [unowned self] in
-        passwordsViewController.navigationItem.prompt = identifier
+            self.credentialProvider.identifier = credentialIdentity.serviceIdentifier
-        passwordsViewController.showPasswordsWithSuggestion(matching: identifier)
+            self.passwordsViewController.navigationItem.prompt = identifier
+            self.passwordsViewController.showPasswordsWithSuggestion(matching: identifier)
+        })
     }
 
     @objc
@@ -68,8 +78,6 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
 
 extension CredentialProviderViewController: PasswordSelectionDelegate {
     func selected(password: PasswordTableEntry) {
-        let passwordEntity = password.passwordEntity
+        credentialProvider.persistAndProvideCredentials(with: password.passwordEntity.getPath())
-
-        credentialProvider.persistAndProvideCredentials(with: passwordEntity.getPath())
     }
 }

passAutoFillExtension/Controllers/PasscodeExtensionDisplay.swift

@@ -19,15 +19,12 @@ class PasscodeExtensionDisplay {
     }
 
     // present the passcode lock view if passcode is set and the view controller is not presented
-    func presentPasscodeLockIfNeeded(_ extensionVC: UIViewController) {
+    func presentPasscodeLockIfNeeded(_ sender: UIViewController, before: (() -> Void)? = nil, after: (() -> Void)? = nil) {
-        extensionVC.view.isHidden = true
+        if PasscodeLock.shared.hasPasscode {
-        guard PasscodeLock.shared.hasPasscode else {
+            before?()
-            extensionVC.view.isHidden = false
+            passcodeLockVC.successCallback = after
-            return
-        }
             passcodeLockVC.modalPresentationStyle = .fullScreen
-        extensionVC.parent?.present(passcodeLockVC, animated: false) {
+            sender.parent?.present(passcodeLockVC, animated: false)
-            extensionVC.view.isHidden = false
         }
     }
 }

passExtension/Controllers/ExtensionViewController.swift

@@ -11,17 +11,20 @@ import MobileCoreServices
 import passKit
 
 class ExtensionViewController: UIViewController {
-    var passcodelock: PasscodeExtensionDisplay {
+    private lazy var passcodelock: PasscodeExtensionDisplay = { [unowned self] in
         PasscodeExtensionDisplay(extensionContext: extensionContext!)
-    }
+    }()
 
-    var embeddedNavigationController: UINavigationController {
+    private lazy var passwordsViewController: PasswordsViewController = {
-        children.first as! UINavigationController
+        (children.first as! UINavigationController).viewControllers.first as! PasswordsViewController
-    }
+    }()
 
-    var passwordsViewController: PasswordsViewController {
+    private lazy var credentialProvider: CredentialProvider = { [unowned self] in
-        embeddedNavigationController.viewControllers.first as! PasswordsViewController
+        CredentialProvider(viewController: self, extensionContext: extensionContext!)
-    }
+    }()
+
+    private lazy var passwordsTableEntries = PasswordStore.shared.fetchPasswordEntityCoreData(withDir: false)
+        .map(PasswordTableEntry.init(_:))
 
     enum Action {
         case findLogin, fillBrowser, unknown
@@ -29,17 +32,16 @@ class ExtensionViewController: UIViewController {
 
     private var action = Action.unknown
 
-    lazy var credentialProvider = CredentialProvider(viewController: self, extensionContext: self.extensionContext!)
-
     override func viewDidLoad() {
         super.viewDidLoad()
-        passcodelock.presentPasscodeLockIfNeeded(self)
+        view.isHidden = true
-
+        passwordsViewController.dataSource = PasswordsTableDataSource(entries: passwordsTableEntries)
-        let passwordsTableEntries = PasswordStore.shared.fetchPasswordEntityCoreData(withDir: false).compactMap { PasswordTableEntry($0) }
-        let dataSource = PasswordsTableDataSource(entries: passwordsTableEntries)
-        passwordsViewController.dataSource = dataSource
         passwordsViewController.selectionDelegate = self
-        passwordsViewController.navigationItem.leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: .cancel, target: self, action: #selector(cancel))
+        passwordsViewController.navigationItem.leftBarButtonItem = UIBarButtonItem(
+            barButtonSystemItem: .cancel,
+            target: self,
+            action: #selector(cancel)
+        )
     }
 
     override func viewWillAppear(_ animated: Bool) {
@@ -47,12 +49,19 @@ class ExtensionViewController: UIViewController {
         prepareCredentialList()
     }
 
+    override func viewDidAppear(_ animated: Bool) {
+        super.viewDidAppear(animated)
+        passcodelock.presentPasscodeLockIfNeeded(self, after: { [unowned self] in
+            self.view.isHidden = false
+        })
+    }
+
     @objc
     private func cancel(_: AnyObject?) {
         extensionContext?.completeRequest(returningItems: nil)
     }
 
-    func prepareCredentialList() {
+    private func prepareCredentialList() {
         guard let attachments = extensionContext?.attachments else {
             return
         }